Fix unit test failure#821
Conversation
ravisantoshgudimetla
force-pushed
the
fix-unit
branch
from
e3beed0 to
c1291c9
Compare
| DockerSearcher: app.DockerClientSearcher{ | ||
| Client: &apptest.FakeDockerClient{ | ||
| Images: []docker.APIImages{{RepoTags: []string{"centos/ruby-27-centos7"}}}, | ||
| Images: []docker.APIImages{{RepoTags: []string{"quay.io/centos7/ruby-27-centos7"}}}, |
There was a problem hiding this comment.
Hmmm... something still looks off, especially that we use that centos/ruby-27-centos7 image in a previous test case. I'll check it more thoroughly on Monday.
There was a problem hiding this comment.
And as discussed yesterday on slack, this test is supposed to work well with no registry image, so you're right, I think something has changed in the response of the apiserver which is causing the problem
There was a problem hiding this comment.
Found the change that triggered this openshift/ruby-hello-world@c90a109 which makes this valid update.
| DockerSearcher: app.DockerClientSearcher{ | ||
| Client: &apptest.FakeDockerClient{ | ||
| Images: []docker.APIImages{{RepoTags: []string{"centos/ruby-27-centos7"}}}, | ||
| Images: []docker.APIImages{{RepoTags: []string{"quay.io/centos7/ruby-27-centos7"}}}, |
There was a problem hiding this comment.
Found the change that triggered this openshift/ruby-hello-world@c90a109 which makes this valid update.
|
Manually adding valid-bug label, since this is fixing test |
soltysh
added
the
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravisantoshgudimetla, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold Till https://bugzilla.redhat.com/show_bug.cgi?id=1959564 gets resolved |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-builds DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
There's only a single failure related with that BZ mentioned earlier, I'm overriding the last failing bit |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Seems like repo update error